Delete the TypedArray polyfill #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Decision: we're going to do this PR, and also add instructions in the readme for users to add their own polyfills. |
The `polyFill()` for TypedArray was causing problems with `purs bundle` v0.14.4. #34 The reference link which the `polyFill()` function comments referred to is dead. Add a section on polyfills to the README, with new reference links.
jamesdbrock
force-pushed
the
polyfill-delete
branch
from
0392a0f to
3e8cb28
Compare
|
Oh, I was surprised that you didn't add the instructions in this PR. |
The instructions are here https://github.com/purescript-contrib/purescript-arraybuffer#usage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
polyFill()for TypedArray was causing problems withpurs bundlev0.14.4. #34
The link which the
polyFill()function referred to is dead.This link shows what appears to be a fully-functional TypedArray
polyfill, which is not what we had in our library. Was our
polyFill()even working at all? I don't know.
https://github.com/zloirock/core-js#ecmascript-typed-arrays
This library will now pass this test for purs 0.14.4, and still passes for 0.14.3.
Resolves #34
There is also #35 to resolve the same issue. We should choose one. I prefer this solution.